Add "TableRelation Field Length" to PlatformCop

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/HasDiagnostic/TableExtRelationLonger.al

@@ -0,0 +1,49 @@
+table 50100 MyTable
+{
+    fields
+    {
+        field(1; [|MyText|]; Text[1])
+        {
+            TableRelation = MyTable2.MyTextExt;
+        }
+
+        field(2; [|MyCode|]; Text[1])
+        {
+            TableRelation = if (MyCode = const('const')) MyTable2.MyCodeExt 
+            else 
+            MyTable2.MyTextExt;
+        }
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}
+
+
+table 50101 MyTable2
+{
+    fields
+    {
+        field(1; MyText; Text[1]) { }
+
+        field(2; MyCode; Text[1]) { }
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}
+
+
+tableextension 50100 MyExtension extends MyTable2
+{
+    fields
+    {
+        field(3; MyTextExt; Text[100]) { }
+
+        field(4; MyCodeExt; Text[100]) { }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/HasDiagnostic/TableRelationImplicitFieldPrimaryKey.al

@@ -0,0 +1,17 @@
+table 50100 "My Table"
+{
+    fields
+    {
+        field(1; MyField; Code[20]) { }
+
+        field(2; [|"My TableRelation Field"|]; Code[10])
+        {
+            TableRelation = "My Table";
+        }
+    }
+
+    keys
+    {
+        key(PK; MyField) { }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/HasDiagnostic/TableRelationImplicitFieldPrimaryKeyWithNamespace.al

@@ -0,0 +1,22 @@
+namespace ALCops.PlatformCop.Setup;
+
+table 50100 "My Table"
+{
+    fields
+    {
+        field(1; MyField; Code[20]) { }
+
+        field(2; [|"My TableRelation Field"|]; Code[10])
+        {
+            TableRelation = ALCops.PlatformCop.Setup."My Other Table";
+        }
+    }
+}
+
+table 50101 "My Other Table"
+{
+    fields
+    {
+        field(1; MyField; Code[20]) { }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/HasDiagnostic/TableRelationLonger.al

@@ -0,0 +1,25 @@
+table 50100 MyTable
+{
+    fields
+    {
+        field(1; [|MyText|]; Text[1])
+        {
+            TableRelation = MyTable.MyTextExt;
+        }
+
+        field(2; [|MyCode|]; Text[1])
+        {
+            TableRelation = if (MyCode = const('const')) MyTable.MyCodeExt
+            else 
+            MyTable.MyTextExt;
+        }
+        field(3; MyTextExt; Text[100]) { }
+
+        field(4; MyCodeExt; Text[100]) { }        
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/HasDiagnostic/TableRelationWithNamespace.al

@@ -0,0 +1,28 @@
+namespace ALCops.PlatformCop.Setup;
+
+table 50100 "My Table"
+{
+    fields
+    {
+        field(1; MyField; Code[20]) { }
+
+        field(2; [|"My TableRelation Field"|]; Code[10])
+        {
+            TableRelation = ALCops.PlatformCop.Setup."My Other Table"."My Field";
+        }
+    }
+
+    keys
+    {
+        key(PK; MyField) { }
+    }
+}
+
+
+table 50101 "My Other Table"
+{
+    fields
+    {
+        field(1; "My Field"; Code[20]) { }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/NoDiagnostic/TableExtRelationEqual.al

@@ -0,0 +1,49 @@
+table 50100 MyTable
+{
+    fields
+    {
+        field(1; [|MyText|]; Text[100])
+        {
+            TableRelation = MyTable2.MyTextExt;
+        }
+
+        field(2; [|MyCode|]; Text[100])
+        {
+            TableRelation = if (MyCode = const('const')) MyTable2.MyCodeExt 
+            else 
+            MyTable2.MyTextExt;
+        }
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}
+
+
+table 50101 MyTable2
+{
+    fields
+    {
+        field(1; MyText; Text[1]) { }
+
+        field(2; MyCode; Text[1]) { }
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}
+
+
+tableextension 50100 MyExtension extends MyTable2
+{
+    fields
+    {
+        field(3; MyTextExt; Text[100]) { }
+
+        field(4; MyCodeExt; Text[100]) { }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/NoDiagnostic/TableExtRelationShorter.al

@@ -0,0 +1,48 @@
+table 50100 MyTable
+{
+    fields
+    {
+        field(1; [|MyText|]; Text[200])
+        {
+            TableRelation = MyTable2.MyTextExt;
+        }
+
+        field(2; [|MyCode|]; Text[200])
+        {
+            TableRelation = if (MyCode = const('const')) MyTable2.MyCodeExt 
+            else 
+            MyTable2.MyTextExt;
+        }
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}
+
+table 50101 MyTable2
+{
+    fields
+    {
+        field(1; MyText; Text[1]) { }
+
+        field(2; MyCode; Text[1]) { }
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}
+
+
+tableextension 50100 MyExtension extends MyTable2
+{
+    fields
+    {
+        field(3; MyTextExt; Text[100]) { }
+
+        field(4; MyCodeExt; Text[100]) { }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/NoDiagnostic/TableRelationEqual.al

@@ -0,0 +1,25 @@
+table 50100 MyTable
+{
+    fields
+    {
+        field(1; [|MyText|]; Text[100])
+        {
+            TableRelation = MyTable.MyTextExt;
+        }
+
+        field(2; [|MyCode|]; Text[100])
+        {
+            TableRelation = if (MyCode = const('const')) MyTable.MyCodeExt
+            else 
+            MyTable.MyTextExt;
+        }
+        field(3; MyTextExt; Text[100]) { }
+
+        field(4; MyCodeExt; Text[100]) { }        
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/NoDiagnostic/TableRelationShorter.al

@@ -0,0 +1,25 @@
+table 50100 MyTable
+{
+    fields
+    {
+        field(1; [|MyText|]; Text[200])
+        {
+            TableRelation = MyTable.MyTextExt;
+        }
+
+        field(2; [|MyCode|]; Text[200])
+        {
+            TableRelation = if (MyCode = const('const')) MyTable.MyCodeExt
+            else 
+            MyTable.MyTextExt;
+        }
+        field(3; MyTextExt; Text[100]) { }
+
+        field(4; MyCodeExt; Text[100]) { }        
+    }
+
+    keys
+    {
+        key(PK; MyText) { Clustered = true; }
+    }
+}

src/ALCops.PlatformCop.Test/Rules/TableRelationFieldLength/TableRelationFieldLength.cs

@@ -0,0 +1,82 @@
+using ALCops.PlatformCop.CodeFixes;
+using RoslynTestKit;
+
+namespace ALCops.PlatformCop.Test
+{
+    public class TableRelationFieldLength : NavCodeAnalysisBase
+    {
+        private AnalyzerTestFixture _fixture;
+        private static readonly Analyzers.TableRelationFieldLength _analyzer = new();
+        private string _testCasePath;
+
+        [SetUp]
+        public void Setup()
+        {
+            _fixture = RoslynFixtureFactory.Create<Analyzers.TableRelationFieldLength>();
+
+            _testCasePath = Path.Combine(
+                Directory.GetParent(
+                    Environment.CurrentDirectory)!.Parent!.Parent!.FullName,
+                    Path.Combine("Rules", nameof(TableRelationFieldLength)));
+        }
+
+        [Test]
+        [TestCase("TableRelationLonger")]
+        [TestCase("TableRelationImplicitFieldPrimaryKey")]
+        [TestCase("TableRelationImplicitFieldPrimaryKeyWithNamespace")]
+        [TestCase("TableExtRelationLonger")]
+        [TestCase("TableRelationWithNamespace")]
+        public async Task HasDiagnostic(string testCase)
+        {
+            SkipTestIfVersionIsTooLow(
+                ["TableExtRelationLonger"],
+                testCase,
+                "13.0",
+                "No support for tableextensions when target itself is already declared in the same module");
+
+            var code = await File.ReadAllTextAsync(Path.Combine(_testCasePath, nameof(HasDiagnostic), $"{testCase}.al"))
+                .ConfigureAwait(false);
+
+            _fixture.HasDiagnosticAtAllMarkers(code, DiagnosticIds.TableRelationFieldLength);
+        }
+
+        [Test]
+        [TestCase("TableRelationEqual")]
+        [TestCase("TableRelationShorter")]
+        [TestCase("TableExtRelationEqual")]
+        [TestCase("TableExtRelationShorter")]
+        public async Task NoDiagnostic(string testCase)
+        {
+            SkipTestIfVersionIsTooLow(
+                ["TableExtRelationEqual", "TableExtRelationShorter"],
+                testCase,
+                "13.0",
+                "No support for tableextensions when target itself is already declared in the same module");
+
+            var code = await File.ReadAllTextAsync(Path.Combine(_testCasePath, nameof(NoDiagnostic), $"{testCase}.al"))
+                .ConfigureAwait(false);
+
+            _fixture.NoDiagnosticAtAllMarkers(code, DiagnosticIds.TableRelationFieldLength);
+        }
+
+        // [Test]
+        // [TestCase("ReplaceSetRangeWithSetFilter")]
+        // [TestCase("ReplaceSetRangeWithSetFilterUsingRec")]
+        // public async Task HasFix(string testCase)
+        // {
+        //     var currentCode = await File.ReadAllTextAsync(Path.Combine(_testCasePath, nameof(HasFix), testCase, "current.al"))
+        //         .ConfigureAwait(false);
+
+        //     var expectedCode = await File.ReadAllTextAsync(Path.Combine(_testCasePath, nameof(HasFix), testCase, "expected.al"))
+        //         .ConfigureAwait(false);
+
+        //     var fixture = RoslynFixtureFactory.Create<TableRelationFieldLengthCodeFix>(
+        //         new CodeFixTestFixtureConfig
+        //         {
+        //             AdditionalAnalyzers = [_analyzer]
+        //         });
+
+        //     fixture.TestCodeFix(currentCode, expectedCode, DiagnosticDescriptors.TableRelationFieldLength);
+        // }
+    }
+}