Full rewrite #35
Full rewrite #35
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const response = await fetch(finalConfig.url, { | ||
| method: finalConfig.method || 'GET', | ||
| headers: finalConfig.headers, | ||
| body: finalConfig.body ? JSON.stringify(finalConfig.body) : undefined, | ||
| ...finalConfig | ||
| }) |
There was a problem hiding this comment.
The new API client attempts to JSON‑encode request bodies but then spreads finalConfig after the stringification step (fetch(finalConfig.url, { …, body: finalConfig.body ? JSON.stringify(finalConfig.body) : undefined, ...finalConfig })). Because the spread comes last, any object supplied in finalConfig.body overwrites the stringified version, so fetch receives a plain object and throws a runtime error for every POST/PUT call with a JSON payload. The spread should occur before the manual serialization or the code should assign the encoded body after the spread.
Useful? React with 👍 / 👎.
Update architecture for + testing + security