Bug: Inconsistency between internal metrics and SciPy due to implicit normalization.#55
Merged
Joao-Paulo-Silva merged 3 commits intoAIS-Package:developfrom Feb 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aisp.utils.distancemodule implements cityblock and minkowski with normalization, dividing the result by the number of dimensions n. aisp also usesscipy.spatial.distance.cdist, and SciPy follows the classic mathematical definition of metrics, returning cumulative distances without dimension-specific normalization.This difference creates an inconsistency that can cause problems in models generated with these distances.