fix: combine competitor evidence improvements#201
Merged
Conversation
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #197 and #199.
What Changed
recommendedCompetitorsstorage/API path from feat: extract and display AI-recommended company names in runs #199recommendedCompetitorsconsistently through run detail, project snapshots, contracts, and testsWhy
#197had the correct UI separation between competitors and sources#199added useful backend data but replaced cited-domain evidence in the modal and exposed the new field inconsistently across snapshot endpointsgroundingSourcesremain raw source records,citedDomainsremain canonical citation evidence, andrecommendedCompetitorsis an additional interpretive layerValidation
pnpm exec vitest run packages/canonry/test/job-runner-competitors.test.ts packages/contracts/test/index.test.ts packages/db/test/index.test.ts packages/api-routes/test/index.test.tspnpm --filter @ainyc/canonry-web run typecheckpnpm --filter @ainyc/canonry run typecheckpnpm --filter @ainyc/canonry-api-routes run typecheckpnpm --filter @ainyc/canonry-contracts run typecheckpnpm --filter @ainyc/canonry-db run typechecklintruns for those same packages