Fix false negative for nested schema types like HowTo#17
Merged
Conversation
The structured data checker only inspected top-level @graph entries, missing schemas nested inside parent objects (e.g. HowTo inside LocalBusiness via hasProcess). Recursively traverse all nested objects to collect @type values at any depth. Consolidates duplicate findSchemaByType into a shared recursive helper used by structured-data, schema-completeness, and eeat-signals analyzers. Closes AINYC/ainyc#87 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add findTopLevelSchemaByType helper and update analyzeEeatSignals to use it for Organization/LocalBusiness/ProfessionalService (top-level only), and for Person use top-level + authorial properties (author, creator, contributor) — catching Article.author patterns without inflating scores from incidental nested references like Review.author or customer schemas. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractSchemaTypesandfindSchemaByType) now recursively traverses nested objects, fixing false negatives for schemas like HowTo nested inside a parent (e.g.LocalBusiness.hasProcess)findSchemaByTypefromschema-completeness.tsandeeat-signals.tsinto a shared recursive helper inhelpers.tsTest plan
pnpm run typecheckpassespnpm testpasses (17/17), including 2 new tests for nested schema detectionCloses AINYC/ainyc#87
🤖 Generated with Claude Code