-
Notifications
You must be signed in to change notification settings - Fork 0
🛡️ Sentinel: Fix insecure postMessage origin in OAuth redirects #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AGI-Corporation
wants to merge
4
commits into
main
Choose a base branch
from
sentinel/fix-insecure-postmessage-origin-redirects-843941654461830414
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
46c64eb
🛡️ Sentinel: [HIGH] Fix insecure postMessage origin in OAuth redirects
google-labs-jules[bot] a7f4aa0
🛡️ Sentinel: Fix insecure postMessage origin in OAuth redirects
google-labs-jules[bot] 2e6528e
fix(security): restrict postMessage target origin in OAuth redirects
google-labs-jules[bot] 8013e62
fix(security): restrict postMessage target origin in OAuth redirects
google-labs-jules[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| ## 2025-05-15 - [HIGH] Insecure postMessage Origin in OAuth Redirects | ||
| **Vulnerability:** Use of wildcard origin (`'*'`) in `window.postMessage` calls within OAuth redirect handlers (both server-side generated HTML and client-side React routes). | ||
| **Learning:** Wildcard origins in `postMessage` allow any site that can open or iframe the redirect page to intercept sensitive information, such as OAuth authorization codes. In a multi-tenant environment (like Activepieces with custom domains), the expected origin must be resolved dynamically. | ||
| **Prevention:** Always restrict the `targetOrigin` to a trusted value. For client-side redirects, use `window.location.origin` if the communication is same-origin. For server-side generated redirects, use platform-aware URL resolvers (e.g., `domainHelper.getPublicUrl`) to determine the correct frontend origin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deriving
targetOriginfromdomainHelper.getPublicUrl({ platformId })here can send the OAuth code to the wrong origin in cloud custom-domain setups that useAP_INTERNAL_URL:THIRD_PARTY_AUTH_PROVIDER_REDIRECT_URLis generated viagetInternalUrl(shared/internal host), so this/redirectrequest may not map to a tenant host,getPlatformIdForRequestfalls back tonull, and the handler posts to the default frontend origin instead of the tenant opener origin. In that environment,window.opener.postMessageis blocked by origin mismatch and the OAuth/SSO popup never returns a code.Useful? React with 👍 / 👎.