Skip to content

🛡️ Sentinel: [MEDIUM] Fix information leakage in API errors #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AGI-Corporation wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🛡️ Sentinel: [MEDIUM] Fix information leakage in API errors #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@
**Vulnerability:** Not a direct security vulnerability, but an environmental instability. The `requirements.txt` allowed `mistralai>=1.1.0`, which pulled in version 2.x.
**Learning:** MistralAI 2.x introduces breaking changes in the client import structure (`from mistralai import Mistral` fails if not using the new client correctly or if expecting the old one). This caused the entire application (including security tests) to fail on startup.
**Prevention:** Pin critical dependencies like `mistralai==1.1.0` in `requirements.txt` to ensure consistent behavior across development and CI environments, especially when using agents that rely on specific API structures.

## 2025-04-12 - [MEDIUM] Fix information leakage in API errors
**Vulnerability:** Raw exception messages (`str(e)`) were being returned directly to the client in HTTP 500 errors in `agents/mistral_agent/agent.py`.
**Learning:** Returning unhandled exception details can leak sensitive internal state, stack traces, or configuration details to potentially malicious actors.
**Prevention:** Ensure all APIs catch general exceptions, log the raw error internally using `logging.error()`, and return a generic, sanitized HTTP 500 message like "Internal server error" to the client.
10 changes: 7 additions & 3 deletions agents/mistral_agent/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"""

import json
import logging
import os
import uuid
from datetime import UTC, datetime
Expand Down Expand Up @@ -318,7 +319,8 @@ async def gap_analysis(req: GapAnalysisRequest, db: AsyncSession = Depends(get_d
"model": MISTRAL_MODEL,
}
except Exception as e:
raise HTTPException(status_code=500, detail=str(e))
logging.error(f"Error in mistral agent: {e}")
raise HTTPException(status_code=500, detail="Internal server error")


@router.post("/code-review", summary="DevSecOps code security analysis with Codestral")
Expand All @@ -333,7 +335,8 @@ async def code_review(req: CodeReviewRequest, db: AsyncSession = Depends(get_db)
)
return {"analysis": result, "model": MISTRAL_CODE_MODEL}
except Exception as e:
raise HTTPException(status_code=500, detail=str(e))
logging.error(f"Error in mistral agent: {e}")
raise HTTPException(status_code=500, detail="Internal server error")


@router.post("/ask", summary="Ask a CMMC/ZT compliance question")
Expand All @@ -343,4 +346,5 @@ async def ask_question(req: QuestionRequest):
answer = await agent.answer_compliance_question(req.question, req.context)
return {"question": req.question, "answer": answer, "model": MISTRAL_MODEL}
except Exception as e:
raise HTTPException(status_code=500, detail=str(e))
logging.error(f"Error in mistral agent: {e}")
raise HTTPException(status_code=500, detail="Internal server error")
Loading