Refactor/node inheritance #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add numpy to requirements-nodes.txt - Create conftest.py for test configuration - Fix test_numpy_subprocess.py to import real numpy before any mocking - Fix test_media.py to import real numpy early - Fix test_image_node_sanitization.py to use MockTensor instead of torch.zeros
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
- test_media.py: Use Python math.log2 instead of numpy to avoid mock issues - test_image_node_sanitization.py: Patch tensor_to_numpy_uint8 and Image.fromarray to properly handle mocked torch tensors
This test requires real PyTorch for tensor iteration which isn't available in CI due to module mocking. The test runs correctly in local dev with torch.
Local testing is more reliable due to ComfyUI/torch dependency requirements. CI environment cannot properly mock these dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.