Add comments around trading #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 6, 2015 13:55
This will fix an issue with not checking the console a user is on when posting an offer, and adds comments to the seeds file
This adds information about trades and offers to the users/show page, and refactors other related table displays into separate partials.
this adds two scopes to the offer model. One will get offers for an open trade, the other will get offers that have been accepted. These now show separately on the users/show page in tables that are in separate tabs, and these tabs have been separated out into their own partials.
There was a problem hiding this comment.
Is it worth making a helper for some of this stuff?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add comments to trade offers to allow discussion through the web application, which is not available in-game. It also updates the db/seeds.rb file to add comments, adds partials for tables to clean up views, and disables turbolinks to fix nested form behavior.
@nhessler @ashirazi @hmadison