-
Notifications
You must be signed in to change notification settings - Fork 3
Refactor DataPreprocessor to steps-based pipeline, add CounterDiffTransformer and PreDist notebook #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough the configuration file, by providing a steps specification instead of a long list of arguments. Extend DataPreprocessor tests with new steps parameter set up. Also ensures the default values of the DataTransformer classes are the same as the defaults in the DataPreprocessor.
…and update tests and test_data (test configuration files) accordingly
… to complement `features_to_exclude`. Update the basic configuration. Fix Docstring in fault_detection_model.py and move initialization of models in fault_detection_result.py here. Fix Docstring in arcana.py.
(cherry picked from commit a4061f8)
…aClipper features_to_exclude and features_to_clip)
…lear up the Hyperopt notebook.
… generate a configuration file.
…counter diffs/rates if they are present in the reconstruction
…he notebook `notebooks/PreDist/PreDist.ipynb` to show how to apply the EnergyFaultDetector on the PreDist dataset. Also adds the `criticality` as method to the `FaultDetectionResult`, for easy access and plotting.
Some refactoring: Moving from os.path to pathlib.Path for file handling (wip).
…, change to float64 through config)
… fault detector clearer
…t_dataset.py to replace string values for.
…ning the file structure.
…docstrings and comments in PreDist.ipynb and predist_utils.py.
cgueck895
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DataPreprocessorto a flexible, steps-based pipeline. This makes it easier to add new steps and data transformers to the framework.CounterDiffTransformerfor robust counter-to-diff/rate conversion (resets, rollovers, gap masking).generate_quickstart_configto create a ready-to-train config (and optional YAML dump).features_to_selectto theColumnSelectoras alternative tofeatures_to_exclude.features_to_clipto theDataClipperas alternative tofeatures_to_exclude.Changes
Example config:
CounterDiffTransformer (new)
Quickstart config generator (new)
Visualisation
plot_reconstruction, but uses theFaultDetector.predictmethod to get the reconstruction. Counter values are plottet as diffs or rates with their reconstruction.PreDist
evaluation.PreDistDataset: A class to (down)load and prepare data from the PreDist dataset.Refactoring
FaultDetectionResultnow also has a method to load saved results and a utility methodcriticality, which wraps theutils.analysis.calculate_criticalityfunction.pathlib.Pathfor file paths as well. Start moving fromos.pathto thepathliblibrary.FaultDetectorto save memory. Iffloat64is needed, this can be configured (Config.dtype).Documentation