Skip to content

Conversation

@teehari79
Copy link
Contributor

No description provided.

teehari79 and others added 30 commits October 5, 2025 07:10
…lt_detector

Add train/predict modes to quick fault detector CLI
…or-wind-turbine-data

Add unsupervised behaviour model for turbine sensor anomalies
…m-dataset

Add utility for splitting asset CSV datasets
…in-train-mode

Add model output customization options for quick fault training
…utation

Handle empty numeric columns during imputation
…or-quickfaultdetector

Add CLI script to run quick fault detector in predict mode
…utation-o1cbmt

Guard preprocessing when time column missing
…-test-file

Adjust prediction defaults for wind farm dataset
…ror-reporting

Improve missing column error message in ColumnSelector
…rediction-records

Add anomaly metadata columns to prediction output
…t-array

Handle missing training data in quick fault detection plots
…ds-in-arcana-model

Add configuration option to ignore ARCANA features
teehari79 and others added 23 commits October 10, 2025 10:06
…-in-predict-method

Ensure FaultDetector.predict propagates ignore feature defaults
…ting-issue

Preserve ignore feature configuration when loading models
…_predict.py

Fix create_events boolean alignment
…ter.py-for-memory-usage

Optimize asset dataset splitter memory usage
…-label-to-predict-mode

Add event identifiers to prediction outputs
…-anomaly-detector

Fix boolean mask handling in anomaly score fitting
…rror

Fix threshold fitting mask alignment
…ng-model-fitting

Avoid large allocations when fitting RMSE anomaly score
…ld-fitting-55jy9a

Fix quantile threshold selector alignment and tests
…-predictions

Add REST prediction API with configurable model registry
@roelofsc
Copy link
Contributor

roelofsc commented Oct 14, 2025

@teehari79 Thank you for the merge request.

Could you please add a summary with a list of changes?
Can you rebase your branch onto the develop branch?

This PR covers a lot of areas, both refactoring and new features. Would it be possible to split up the changes into:

  • Bug fixes / improvements / refactoring
  • REST API prediction endpoint
  • LLM powered narrative endpoint
  • Changes to the QuickFaultDetector feature
  • Any other added features?

@roelofsc roelofsc changed the base branch from main to develop October 15, 2025 08:00
@roelofsc
Copy link
Contributor

@teehari79 The quick_fault_detector does not seem to work with this version anymore. I tested it with the event 44 dataset from the CAREToCompare dataset (quick_fault_detector --c2c_example 'path_to_datasets\Wind_Farm_C\datasets\44.csv').
ARCANA losses are set to 'None' for some detected events (there is an error in 'visualisation.plot_arcana_losses', which is called in 'quick_fault_detection.output.generate_output_plots'). There is no traceback; the last part of the logs is as follows:

configured_ignore_patterns: ('power_2_avg', 'power_5_avg', 'power_6_avg', 'power_17_avg', 'wind_speed_236_avg', 'wind_speed_235_avg', 'wind_speed_237_avg')
1643/1643 [==============================] - 5s 3ms/step
2025-10-20 08:53:30,177 - energy_fault_detector - INFO - Ignoring 7 feature(s) for anomaly scoring (prediction): power_17_avg, power_2_avg, power_5_avg, power_6_avg, wind_speed_235_avg, wind_speed_236_avg, wind_speed_237_avg
2025-10-20 08:53:45,712 - energy_fault_detector - ERROR - An error occurred: 'NoneType' object has no attribute 'columns'

Since the refactoring and bug fixes look promising, I will take a closer look at the individual commits. This will take some time, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants