Small improvements to balance estimation #2305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We refactor the balance estimates to be bundled with the graph in router data. This lets the compiler find for us places where we forgot to update balances, such as when pruning channels. The changes to Validation.scala are probably easier to compare against master than comparing them to the base PR, they make the change more obvious compared to master. We almost never use the `a max b` syntax in the codebase, we always use a more explicit function call, so I updated it in BalanceEstimate for consistency. This commit doesn't contain meaningful business logic changes and should be easy to review.
* Fix division by zero * Add didReceive * Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR on #2272
It contains two commits that should be reviewed separately.
Please read the commit messages, they contain more details about each commit.
This first commit doesn't contain any meaningful logic changes, it's mostly refactoring and code clean-up, it should be quite straight-forward even though it contains many line changes.
The second commit focuses on the balance estimation business logic, and I'm curious to get your thoughts. It does two things: add a
didReceive(symmetric todidSend) and fix a division by zero. I spent a lot of time trying to figure out if we could do a more meaningful update in the parallel channels case ofdidSend, it feels like we're not doing enough, but I didn't find a better solution...