Dedicated event for channel_update modifications
#1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
==========================================
- Coverage 87.53% 8.98% -78.56%
==========================================
Files 158 158
Lines 12231 12273 +42
Branches 505 531 +26
==========================================
- Hits 10707 1103 -9604
- Misses 1524 11170 +9646
|
The `Register` should be used to channel actors, not the `Router`. The former tracks all channels, whereas the latter only contains channels in certain states. We only query the `Router` when we need reference to external (public) nodes and channels.
thomash-acinq
previously approved these changes
Sep 3, 2021
pm47
commented
Sep 3, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
previously approved these changes
Sep 3, 2021
t-bast
reviewed
Sep 3, 2021
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Concept ACK, a couple small comments
eclair-core/src/test/scala/fr/acinq/eclair/channel/RestoreSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/RestoreSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/RestoreSpec.scala
Outdated
Show resolved
Hide resolved
t-bast
previously approved these changes
Sep 3, 2021
thomash-acinq
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use an event
ChannelUpdateParametersChangedfor the sole purpose of tracking changes tochannel_update.First two commits are a rebase on improvements made in previous PRs (mostly simplify the restore flow by including it in the general "update while offline" scenario from #1922).
🤞