Keep former channel_update in channel state
#1934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to #1918 (ef31de1), but we use the internal actor state instead of the `ChannelData`. Pros: - conceptually simple, low risk of regression - `ChannelData` stays untouched Cons: - now there is a `var` in the channel Those are the minimal changes to have the simplest diff, but we can include some improvements made in ef31de1.
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
==========================================
+ Coverage 87.53% 87.61% +0.07%
==========================================
Files 158 158
Lines 12231 12268 +37
Branches 505 520 +15
==========================================
+ Hits 10707 10749 +42
+ Misses 1524 1519 -5
|
thomash-acinq
approved these changes
Sep 2, 2021
This was referenced Sep 2, 2021
t-bast
approved these changes
Sep 2, 2021
Member
Author
|
And.... still doesn't work 😒. For the same reasons as #1922 (comment). If we send multiple The root cause of all our problems is that we should not reuse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to #1918 (ef31de1), but we use the internal
actor state instead of the
ChannelData.Pros:
ChannelDatastays untouchedCons:
varin the channelThose are the minimal changes to have the simplest diff, but we can
include some improvements made in ef31de1.