add new methods and update testing for accuracy#14
Draft
MacdonaldJoshuaCaleb wants to merge 3 commits intoreduce_introspectionfrom
Draft
add new methods and update testing for accuracy#14MacdonaldJoshuaCaleb wants to merge 3 commits intoreduce_introspectionfrom
MacdonaldJoshuaCaleb wants to merge 3 commits intoreduce_introspectionfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands the Operator-Partitioned Engine (OP Engine) to support new stiff ODE solvers, enhances test coverage for these methods, and improves documentation and code quality. The main changes include adding fully implicit and Rosenbrock methods, updating the test suite to validate their accuracy and requirements, and clarifying the public API in the documentation.
Solver and API enhancements:
implicit-euler,trapezoidal,bdf2,ros2) toCoreSolver, including optional Jacobian support, and updated the README to reflect these new capabilities. [1] [2]Testing improvements:
MethodNameliteral andScalarRunCasedataclass to handle new methods and Jacobians, and added comprehensive accuracy and convergence tests for the new implicit solvers. [1] [2] [3] [4] [5] [6] [7] [8] [9]Code quality and linting:
pyproject.tomlto ignore thePLR0914linting rule in test files, reducing noise from parameter count warnings in pytest functions.Minor test maintenance:
noqa: PLR0914comments from test functions after updating linting configuration. [1] [2]