Skip to content

[WIP] Fix issues from CI run#13

Merged
MacdonaldJoshuaCaleb merged 2 commits intomainfrom
copilot/fix-ci-issues
Feb 13, 2026
Merged

[WIP] Fix issues from CI run#13
MacdonaldJoshuaCaleb merged 2 commits intomainfrom
copilot/fix-ci-issues

Conversation

Copy link
Contributor

Copilot AI commented Feb 13, 2026

  • Fix pyproject.toml: Change [tool.uv] version to required-version with >=0.4.17
  • Fix floating point equality comparisons in tests/op_engine/test_model_core.py (2 issues)
  • Run CI checks locally to verify all fixes (all pass)
  • Run code review and security scans (no issues found)

Summary

Fixed all CI issues in the copilot/fix-ci-issues branch:

Changes Made:

  1. pyproject.toml: Changed [tool.uv] section from invalid version = "0.4.17" to correct required-version = ">=0.4.17"
  2. test_model_core.py: Fixed 2 floating point equality comparisons (RUF069 errors):
    • Line 84: Changed core.dt == 0.0 to np.isclose(core.dt, 0.0)
    • Line 425: Changed core.current_state[0, 0] == 42.0 to np.isclose(core.current_state[0, 0], 42.0)

Verification:

  • ✅ All ruff formatting checks pass
  • ✅ All ruff linting checks pass (0 errors)
  • ✅ All 86 pytest tests pass in core
  • ✅ All 39 pytest tests pass in provider
  • ✅ All mypy type checks pass (strict mode)
  • ✅ Code review: No issues found
  • ✅ Security scan (CodeQL): No vulnerabilities found

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…g point comparisons

Co-authored-by: MacdonaldJoshuaCaleb <72512262+MacdonaldJoshuaCaleb@users.noreply.github.com>
@MacdonaldJoshuaCaleb MacdonaldJoshuaCaleb marked this pull request as ready for review February 13, 2026 16:08
@MacdonaldJoshuaCaleb MacdonaldJoshuaCaleb merged commit ec06374 into main Feb 13, 2026
Copilot stopped work on behalf of MacdonaldJoshuaCaleb due to an error February 13, 2026 16:09
@MacdonaldJoshuaCaleb MacdonaldJoshuaCaleb deleted the copilot/fix-ci-issues branch February 17, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants