Add axes top level key to configuration format#164
Open
TimothyWillard wants to merge 1 commit intomainfrom
Open
Add axes top level key to configuration format#164TimothyWillard wants to merge 1 commit intomainfrom
axes top level key to configuration format#164TimothyWillard wants to merge 1 commit intomainfrom
Conversation
Added the concept of 'axes' to represent a single dimension for something that has shape. Axes can take the form of categorical like 'unvaccinated' and 'vaccinated' or 'low', 'medium', 'high' as well as numerical forms like ages being represented by integers or physical space being represented by a continuous (by discretized) axis. This provides a foundation for further structuring parameters and systems by giving them shape. - Added `axes` attribute to the `ConfigurationModel` class to contain a mapping of named axes that can be used throughout a configuration file. - Added `CategoricalAxisModel`, `IntegerAxisModel`, and `ContinuousAxisModel` classes to represent the three different kinds of axis provided by `flepimop2`. These classes represent the configuration form of these axes objects, including pydantic based validations. - Added an `Axis` class to represent a realized `Axis` object that can be handed off to parameters, systems, etc. This provides a unified interface for those modules to create objects of appropriate size. Heavily inspired by work from @MacdonaldJoshuaCaleb on `ACCIDDA/op_system`. Closes #147.
Member
|
I think we want something like this capability, but I'm not sure what that capability should look like because I'm uncertain of how we plan to use it. I'm basically thinking of axes as:
What else do they get used for? When are they necessary (vs convenient)? Can we get some concept documentation now? As "imagine your model is an ODE, then axes mean this, get expressed like this. Translate that model to a PDE, the axes mean this. An ABM, the axes mean ..." @MacdonaldJoshuaCaleb need your perspective here as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the concept of 'axes' to represent a single dimension for something that has shape. Axes can take the form of categorical like 'unvaccinated' and 'vaccinated' or 'low', 'medium', 'high' as well as numerical forms like ages being represented by integers or physical space being represented by a continuous (by discretized) axis. This provides a foundation for further structuring parameters and systems by giving them shape.
axesattribute to theConfigurationModelclass to contain a mapping of named axes that can be used throughout a configuration file.CategoricalAxisModel,IntegerAxisModel, andContinuousAxisModelclasses to represent the three different kinds of axis provided byflepimop2. These classes represent the configuration form of these axes objects, including pydantic based validations.Axisclass to represent a realizedAxisobject that can be handed off to parameters, systems, etc. This provides a unified interface for those modules to create objects of appropriate size.Heavily inspired by work from @MacdonaldJoshuaCaleb on
ACCIDDA/op_system. Closes #147.