Merged
Conversation
No major changes, mostly just internal clean up focused on consolidation. Namely: - Removed test fixtures no longer needed since they are created in `setup.R`. - Add `override_warning` flag to `check_model` to bypass the attribute override warning, used by `time` and `strata` which provide their own more detailed warnings. - Allow users to provide an integerish value for `population` to `SeverityEstimateModel`. Under the hood `SeverityEstimateModel` just converts the given value to a data.frame with a single observation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No major changes, mostly just internal clean up focused on
consolidation. Namely:
setup.R.override_warningflag tocheck_modelto bypass the attributeoverride warning, used by
timeandstratawhich provide their ownmore detailed warnings.
populationtoSeverityEstimateModel. Under the hoodSeverityEstimateModeljustconverts the given value to a data.frame with a single observation.