Allow libaccessom2 to be used in other CMake projects using find_package #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
micaeljtoliveira
approved these changes
May 13, 2025
Member
micaeljtoliveira
left a comment
micaeljtoliveira
left a comment
There was a problem hiding this comment.
I can't see any obvious issues in the added code, so will approve.
Collaborator
Author
|
Thanks @micaeljtoliveira. I'll wait for @harshula's nod of approval before merging. |
harshula
reviewed
May 14, 2025
|
I'm not familiar enough with the CMake side to review this, so please go ahead and merge since @micaeljtoliveira has reviewed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR allow libaccessom2 to be used in other CMake projects using
find_package: