io_pio: multiple history timesteps per file

[anton-seaice]

The goal here is to enable multiple timesteps per history file when using PIO, to be consistent with the access-esm1.6 branch. In the access-esm1.6 branch, this change was implemented only when using Netcdf for IO. Closes #58

1. This change relies on latest in ParallelIO (Collective access when extending a file NCAR/ParallelIO#2016). (Updating ParallelIO is not answer changing - build and repro )
2. This changes the time variable to be in the middle of the averaging interval
3. error handling is added/modified on an as needed basis, rather than comprehensively
4. Output files follow the ocean convention now, e.g iceh-1monthly-mean_1900.nc

Resulting build is bfb. History output is the same:

Baseline for comparison: /g/data/tm70/as2285/payu/om2-pio/baseline-dev-025deg_jra55_ryf/archive
New output: /g/data/tm70/as2285/payu/om2-pio/pio-dev-025deg_jra55_ryf/archive

[anton-seaice]

@dougiesquire @blimlim - can you take a look sometime. Ill revert the manifest changes before merging

[anton-seaice]

@CodeGat - tell me the CI failure is not my fault :)

The self-hosted runner lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

[CodeGat]

The CI error is not your fault @anton-seaice :) the cluster that hosts the self-hosted runner is being starved of resources due to a lot of parallel builds. This will inform what the limit is for concurrent runners - thanks!

[dougiesquire]

Thanks @anton-seaice. Looks great.

The indentation is very inconsistent. Might be worth going through and making sure that at least the code you added is consistent.

[anton-seaice]

I think i addressed all the comments @dougiesquire

[dougiesquire]

Are all your review-related changes in the most recent commit (da19cf1)?

[anton-seaice]

No sadly - this is the diff:

https://github.com/ACCESS-NRI/cice5/compare/e223d2f..4669d17a2b54c1e2c3e6ea7251f77eca66ad0b27

[dougiesquire]

Thanks @anton-seaice. Great stuff. Just waiting on your response to this before hitting approve

[dougiesquire]

@anton-seaice are the build-ci failures expected?

[anton-seaice]

Finally got there @dougiesquire !

[dougiesquire]

Nice! So do you want to do an ACCESS-OM2 release?