add TemporalWindow test #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoyango
force-pushed
the
temporalwindow_test
branch
2 times, most recently
from
ed85bdc to
7af32cc
Compare
Pull Request Test Coverage Report for Build 19254324483Details
💛 - Coveralls |
edoyango
force-pushed
the
temporalwindow_test
branch
2 times, most recently
from
c96a66f to
b1925ae
Compare
edoyango
force-pushed
the
temporalwindow_test
branch
from
b1925ae to
3330ed1
Compare
Collaborator
|
Looks good. You could consider parameterising the expected results along with the inputs so you don't need that if statement at the end to recognise which case you're in, but it all check out so I'm merging it. Thanks! |
Collaborator
Author
|
good point about parametrsing outputs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple test for the TemporalWindow modification class.