Remove BackwardsCompatibility uses #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjamesdev
changed the title
tennlee
reviewed
Sep 16, 2025
Pull Request Test Coverage Report for Build 17756055427Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
* `sel` * `isel` * `point_box` * `lookup` * `from_shapefile` * `from_geosearch`
* `replace_value` * `dataset`
* `trim` -> `Trim` * `variable_trim` -> `Trim` * `drop` -> `Drop`
* `force_standard_dimension_names` -> `StandardDimensionNames` * `expand` -> `Expand`
mattjamesdev
changed the title
tennlee
reviewed
Sep 16, 2025
| from pyearthtools.utils.decorators import BackwardsCompatibility | ||
|
|
||
| # Backwards compatability | ||
| rename_variables = attr.rename |
Collaborator
There was a problem hiding this comment.
Can you please tidy this up in a new PR?
gemmaellen
pushed a commit
to gemmaellen/PyEarthTools
that referenced
this pull request
Oct 1, 2025
* Replace set_attributes with SetAttributes * Replace set_encoding with SetEncoding * Replace set_type with SetType * Replace rename with Rename * Remove unnecessary renaming of SetAttributes to `update` * Replace TimeSeries* related functions * Remove deprecated TemporalDifference (unreferenced) * Remove deprecated `fill` (unreferenced) * Remove deprecated functions from `region.py` * `sel` * `isel` * `point_box` * `lookup` * `from_shapefile` * `from_geosearch` * Replace `expand` with `Expand` * Remove deprecated `pad` (unreferenced) * Remove deprecated functions from `mask.py` * `replace_value` * `dataset` * Remove deprecated functions from `variables.py` * `trim` -> `Trim` * `variable_trim` -> `Trim` * `drop` -> `Drop` * Remove deprecated `interpolate_na` (unused) * Remove deprecated functions from `dimensions.py` * `force_standard_dimension_names` -> `StandardDimensionNames` * `expand` -> `Expand` * Replace `derive` with `Derive` * Remove deprecated `rechunk` (unused) * Run black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes BackwardsCompability uses throughout the repo.
Fixes #45.
Testing
Test suite was run locally after every commit.