-
Notifications
You must be signed in to change notification settings - Fork 0
Update README.md to suggest how users should #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As discussed with @ccarouge @aidanheerdegen this afternoon, this text is currently misleading as a mixed approach is being used where eventually the plan is to move to a per repository access basis. Perhaps text like I've suggested could be used eventually? Alternatively, can this text please be updated to reflect the current suggested approach? Have admins of all the current organisation's repos been informed of the change / update of the READMEs as appropriate?
Updating because of this updated protocol: ACCESS-Community-Hub/.github#1 FYI @aekiss
micaeljtoliveira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisb13 I agree that the text needs updating. I've made a small suggestion to make it clearer.
|
Thanks for the update @micaeljtoliveira What is the status of this?
I hadn't on the esm1.6 one but I'm not an admin. Were you aware @blimlim? |
Co-authored-by: Micael Oliveira <micael.oliveira@anu.edu.au>
I don't think this has been done yet. |
Not previously, but am now! |
|
Thanks both. I don't think we can merge this until that has been done. The new instructions are otherwise misleading. @micaeljtoliveira can you please merge once that is completed. Just a thought, could save people some work to have examples of how that's been done, so feel free to share this example. |
* Update README.md Updating because of this updated protocol: ACCESS-Community-Hub/.github#1 FYI @aekiss * Update README.md * Update README.md * Apply suggestions from code review Co-authored-by: minghang.li <24727729+minghangli-uni@users.noreply.github.com> * Update README.md few small tweaks * Update README.md --------- Co-authored-by: minghang.li <24727729+minghangli-uni@users.noreply.github.com>
|
So is the plan to merge this? |
We discussed what's the best way to communicate the proposed changes, as there's no obvious communication channel to all the organisation members. One suggestion is to use a PR in this repo to ping all users and/or repo admins. If we go with that idea, it's probably better to open a new PR and implement all changes to the Readme there. |
Oh I see, sounds prudent but can't you just ping everyone here or am I missing something? Also, how did you find this PR? I can't actually see a way to browse PRs that are at an organisational not repo level? |
Yes, we could, but this PR has already quite a few comments that could make things confusing for the people being pinged.
I don't think there is such a thing as a organisational level PR. This PR is part of a repo. Although it's treated in a special way for some things, it's still a normal repo for most purposes. |
As discussed with @ccarouge @aidanheerdegen this afternoon, this text is currently misleading as a mixed approach is being used where eventually the plan is to move to a per repository access basis. Perhaps text like I've suggested could be used eventually?
Here's an example where it's been confusing for own staff. Shame GH doesn't have a join button!
Alternatively, can this text please be updated to reflect the current mixed approach? Have admins of all the current organisation's repos been informed of the change / update of the READMEs as appropriate?
FWIW, here is what I've proposed for esm1.6, along with an issue template: