Adding joint movements into the wholebody scaffold#286
Open
0huitzil wants to merge 71 commits intoABI-Software:mainfrom
Open
Adding joint movements into the wholebody scaffold#2860huitzil wants to merge 71 commits intoABI-Software:mainfrom
0huitzil wants to merge 71 commits intoABI-Software:mainfrom
Conversation
…of the thorax would show up as exterior in the scaffold)
…upper leg elements by getting rid of the leg to foot group
…nt and node numbers
|
@0huitzil do these tests need to pass before RC reviews it? |
Contributor
Author
|
@dananana-batman This is the PR for the joints itself. The tests are very sensitive to small changes in the scaffold, which I have to adjust every time I push changes to it. For the sake of time, I only update them semi-regularly. Though I will make sure to update them again once RC is back and has time to look at the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuous work regarding the addition of joint flexion and abduction movements into the wholebody scaffold.
Highlights