Open
Conversation
rchristie
requested changes
Aug 19, 2022
Member
rchristie
left a comment
rchristie
left a comment
There was a problem hiding this comment.
We need to discuss the comment and how to fix things.
Comment on lines
+1171
to
+1185
| markerTermNameBrainstemCoordinatesMap = { | ||
| # "pudendal nerve": [0.0, 1.0, 0.0], | ||
| # "pelvic splanchnic nerve": [0.0, 1.0, 0.0], | ||
| # "hypogastric nerve": [0.0, 1.0, 0.0], | ||
| # "lumbar splanchnic nerve": [0.0, 1.0, 0.0], | ||
| "fundus of urinary bladder": [14.6, 0.01, 23.1], | ||
| "external urethral sphincter": [-1.5, 6.7, 110.5], | ||
| } | ||
| bladder_coordinates = findOrCreateFieldCoordinates(fm) | ||
| nodeIdentifier = max(1, getMaximumNodeIdentifier(nodes) + 1) | ||
| for termName, brainstemCoordinatesValues in markerTermNameBrainstemCoordinatesMap.items(): | ||
| annotationGroup = findOrCreateAnnotationGroupForTerm(annotationGroups, region, get_bladder_term(termName)) | ||
| annotationGroup.createMarkerNode(nodeIdentifier, bladder_coordinates, brainstemCoordinatesValues) | ||
| nodeIdentifier += 1 | ||
|
|
Member
There was a problem hiding this comment.
Firstly, this would be OK if bladder_coordinates exist, but they do not.
(And it would need to use "bladder" rather than "brainstem" so the latter word should not appear anyway.)
Currently this will only work for human and when no-one changes any central path or size parameters, since coordinates are being used as material coordinates.
We need to discuss what's best here; I think it's better to use only element & xi until actual material coordinates exist. The above code won't work for other species - the locations will be different/wrong for other species.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markers for Keast nerves