Skip to content

Upgrade flatmap-viewer to 4.4.3. #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-wu merged 2 commits into from
Nov 25, 2025
Merged

Upgrade flatmap-viewer to 4.4.3. #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604976b
Upgrade flatmap-vieweer to 4.4.3.
alan-wu Nov 23, 2025
d498e8a
Add a small tolerance for test flatmap visual test..
alan-wu Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cypress/component/VisualTest.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable no-alert, no-console */
const ERROR_TOLERANCE = 0.00384;
const ERROR_TOLERANCE = parseFloat(Cypress.env('ERROR_TOLERANCE'));
// Ref: flatmap-viewer/src/layers/styling.ts
const STROKE_INTERPOLATION = [
'interpolate',
Expand Down Expand Up @@ -104,7 +104,7 @@ describe('MultiFlatmapVuer Screenshot Comparison', () => {

// Test with saved screenshot from fixture
cy.get('@viewerCanvas').compareSnapshot('test-canvas').then(comparisonResults => {
expect(comparisonResults.percentage, 'Viewer map should match test-canvas.png exactly').to.equal(0);
expect(comparisonResults.percentage, 'Viewer map should be almost identical.').to.be.lessThan(ERROR_TOLERANCE);
});

// NOTE: disable base map comparison for now
Expand Down
2 changes: 1 addition & 1 deletion src/services/flatmapLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* a single source for the flatmap-viewer library import
*/
import * as flatmap from 'https://cdn.jsdelivr.net/npm/@abi-software/flatmap-viewer@4.4.2/+esm';
import * as flatmap from 'https://cdn.jsdelivr.net/npm/@abi-software/flatmap-viewer@4.4.3/+esm';

export default flatmap;
Loading