refactor: unify read_aet, extract_aet, and read_smips into read_tern#24
Merged
refactor: unify read_aet, extract_aet, and read_smips into read_tern#24
Conversation
Replace separate reader functions (read_aet, extract_aet, read_smips) with a single read_tern() dispatcher that routes by dataset ID. This simplifies the user-facing API and makes it easier to add new TERN datasets in the future. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reorder read_tern() so dataset ID and argument validation run before get_key(), allowing CI tests to pass without TERN_API_KEY. Update _pkgdown.yml to reference read_tern instead of removed read_aet, read_smips, and extract_aet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add .devcontainer, _pkgdown.yml, CODE_OF_CONDUCT.md, LICENSE.md, and README.Rmd to .Rbuildignore to suppress hidden-file and non-standard-file warnings that cause CI to fail with error-on: "warning". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update generated .Rd file to match the code signature change, fixing the R CMD check warning about mismatched default values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace separate reader functions (read_aet, extract_aet, read_smips) with a single read_tern() dispatcher that routes by dataset ID. This simplifies the user-facing API and makes it easier to add new TERN datasets in the future.
Add the entire collection of TERN-downloadable datasets.