Skip to content

fix: warning: xmake f --buildir= has been deprecated, please use xmake f -o/--builddir=#3

Closed
MMitsuha wants to merge 4 commits intoA2va:mainfrom
MMitsuha:main
Closed

fix: warning: xmake f --buildir= has been deprecated, please use xmake f -o/--builddir=#3
MMitsuha wants to merge 4 commits intoA2va:mainfrom
MMitsuha:main

Conversation

@MMitsuha
Copy link
Contributor

No description provided.

@MMitsuha
Copy link
Contributor Author

MMitsuha commented Jul 14, 2025

also i have noticed that in windows there no LinkKind of "system", only "syslinks". Because of that LinkKind::from_str will return an error ParsingError::InvalidKind, leading to auto-link failure.

here is a dump of build info

{"includedirs_target.m0n1t0r-cpp-windows-lib": ["include", "..\\..", "..\\..\\target\\cxxbridge\\rust"], "linkdirs": ["C:\\Users\\mmits\\AppData\\Local\\.xmake\\packages\\n\\ninja\\v1.12.1\\f99acdf63a7d4fc88c165b22351691b6\\bin", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\Tools\\", "C:\\Users\\mmits\\m0n1t0r\\target\\debug\\deps", "C:\\Users\\mmits\\AppData\\Local\\.xmake\\packages\\c\\cmake\\4.0.3\\5249d11949644178abe2f58a6ffb0624\\bin", "C:\\Users\\mmits\\AppData\\Local\\Microsoft\\WindowsApps", "C:\\Users\\mmits\\m0n1t0r\\target\\debug\\build\\m0n1t0r-client-8016eedd381c12dc\\out\\windows\\x64\\debug", "C:\\Users\\mmits\\scoop\\persist\\rustup\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib", "C:\\Program Files (x86)\\Windows Kits\\10\\Microsoft Application Virtualization\\Sequencer\\", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\VC\\VCPackages", "C:\\Windows\\System32\\OpenSSH\\", "C:\\Users\\mmits\\scoop\\shims", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\CMake\\CMake\\bin", "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\vcpkg", "C:\\Users\\mmits\\scoop\\apps\\pwsh\\7.5.0", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\\\MSBuild\\Current\\Bin\\amd64", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\TeamFoundation\\Team Explorer", "C:\\Program Files (x86)\\Microsoft SDKs\\Windows\\v10.0A\\bin\\NETFX 4.8 Tools\\x64\\", "C:\\Windows\\Microsoft.NET\\Framework64\\v4.0.30319", "C:\\Users\\mmits\\scoop\\apps\\vscode\\current\\bin", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\CMake\\Ninja", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\FSharp\\Tools", "C:\\Users\\mmits\\.dotnet\\tools", "C:\\Windows\\system32", "C:\\Users\\mmits\\scoop\\apps\\gnupg\\current\\bin", "C:\\Users\\mmits\\scoop\\apps\\rustup\\current\\.cargo\\bin", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\VC\\Linux\\bin\\ConnectionManagerExe", "C:\\Program Files\\dotnet\\", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Team Tools\\DiagnosticsHub\\Collector", "C:\\Program Files (x86)\\Windows Kits\\10\\bin\\10.0.26100.0\\\\x64", "C:\\Users\\mmits\\AppData\\Local\\.xmake\\packages\\l\\libpeconv\\2024.09.06\\de94a81c8aa0419db50facfede28f1b4\\lib", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\", "C:\\Users\\mmits\\m0n1t0r\\target\\debug", "C:\\Program Files (x86)\\Windows Kits\\10\\bin\\\\x64", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\TestWindow", "C:\\Windows\\System32\\Wbem", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.43.34808\\bin\\HostX64\\x64", "C:\\Users\\mmits\\scoop\\persist\\rustup\\.cargo\\bin", "C:\\Windows", "C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\MSBuild\\Current\\bin\\Roslyn", "C:\\Program Files (x86)\\Windows Kits\\10\\Windows Performance Toolkit\\"], "includedirs_package.libpeconv": ["C:\\Users\\mmits\\AppData\\Local\\.xmake\\packages\\l\\libpeconv\\2024.09.06\\de94a81c8aa0419db50facfede28f1b4\\include"], "links": ["m0n1t0r-cpp-windows-lib/static", "libpeconv/static", "kernel32/syslinks", "ntdll/syslinks"], "stl_used": ["false"], "cxx_used": ["true"]}

@A2va
Copy link
Owner

A2va commented Jul 14, 2025

Thank you, but I would rather not merge the builddir fix because it would require to bump XMAKE_MINIMUM_VERSION to xmake v3 and I want the v0.3.x series to still supports < v3.

I plan to bump the minimum xmake version to v3 in the v0.4.x series.

@MMitsuha
Copy link
Contributor Author

okay, I will open a new branch and pr to fix the link problem in windows later

@MMitsuha MMitsuha closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants