Conversation
… error handling - Add yes/no confirmation modals before clearing memory and biblion - Fix delete operations to pass directory parameter for proper functionality - Add error handling with detailed error messages in toasts - Add double-click guard to prevent multiple simultaneous deletion attempts - Remove TODO list from sidebar panel and SessionTodoDock import - Clean up unused signal and role state variables
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces accidental data loss in the session info panel by adding a confirmation step before clearing Memory/Biblion, improves deletion reliability by passing the directory context explicitly, and removes the Tasks/TODO section from the panel UI.
Changes:
- Added a reusable confirmation dialog component and wired it to Memory/Biblion “trash” actions.
- Updated Memory/Biblion clear calls to pass
directoryexplicitly and surface failures via error toasts. - Removed the Tasks section (and its related imports/state) from the session info panel.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Changes