Skip to content

Conversation

@shalithasuranga
Copy link

@shalithasuranga shalithasuranga commented Sep 1, 2017

This closes #109

Explanation
Issue was the height was 0px due to inner floated elements. I just added display : table

@dinukadesilva
Copy link

@shalithasuranga This issue causes due to the missing bootstrap classes. And adding them fixes this. And no need of changing display to table which is kind of not recommended in bootstrap.

If you could add the following missing classes to all the places where it's missing, this would be solved.

col-lg-12 col-md-12 col-sm-12 col-xs-12

@shalithasuranga
Copy link
Author

shalithasuranga commented Sep 4, 2017

@dinukadesilva Thanks for the idea. if we use col-lg-12 will stretch to the screen. How about using clearfix class. I already pushed to this PR.

Thanks

@dinukadesilva
Copy link

That way it works I guess. But, I would prefer having defined all four classes. BTW there are few other places this has to be updated in index.js.

@shalithasuranga
Copy link
Author

Hi @dinukadesilva clearfix solves the issue. Btw To where you are suggesting to add col-lg-12 col-md-12 col-sm-12 col-xs-12 classes ?

@dinukadesilva
Copy link

I'll let you decide whether it's clearfix or adding all four grid CSS classes. There few places in index.js missing some grid CSS classes that you have to update though it's working.

eg:-
https://github.com/99xt/99xt.github.io/blob/7ab550a0e761dc8ad9666024fff878293ac507d5/js/index.js#L149

@chamathpali
Copy link

Whats the status on this @dinukadesilva @shalithasuranga ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respositories are not clickable from mobile device

3 participants