6% perf gain: Don't write fields to strings preemptively#71
Merged
Conversation
This seems to improve performance by 5.7%!
format event/colors, wrapping, stderr
time: [11.696 µs 11.714 µs 11.737 µs]
change: [-6.2772% -5.7379% -5.1220%] (p = 0.00 < 0.05)
format event/colors, wrapping
time: [5.2662 µs 5.2711 µs 5.2747 µs]
change: [-14.121% -13.943% -13.777%] (p = 0.00 < 0.05)
format event/no colors, wrapping
time: [5.1020 µs 5.1102 µs 5.1164 µs]
change: [-10.160% -10.017% -9.8873%] (p = 0.00 < 0.05)
format event/colors, no wrapping
time: [1.7943 µs 1.7968 µs 1.8006 µs]
change: [-25.048% -24.892% -24.716%] (p = 0.00 < 0.05)
format event/no colors, no wrapping
time: [1.4897 µs 1.4916 µs 1.4947 µs]
change: [-22.072% -21.960% -21.832%] (p = 0.00 < 0.05)
1bd073a to
ff03472
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to improve performance by 5.7%!