-
Notifications
You must be signed in to change notification settings - Fork 0
Update 8hobbies/workflows digest to d98caf4 #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| jobs: | ||
| lint: | ||
| uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@aeea4ef82ae99732c467d6245294bbed0e0fa426 | ||
| uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@d98caf412242294b1c9060cab2e30ecc9c55a0f7 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix the issue, we must add an explicit permissions block to the workflow file .github/workflows/lint.yml. Because the workflow only delegates jobs to a reusable workflow, the safest setting is global read-only access (the recommended starting point): permissions: contents: read. This should be placed at the root level, above the jobs: key, so it applies to all jobs unless overridden. No further changes are necessary, since the workflow does not appear to require write permissions for its own logic.
-
Copy modified lines R17-R19
| @@ -14,6 +14,9 @@ | ||
|
|
||
| name: Lint | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: ["master"] |
| jobs: | ||
| run: | ||
| uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@aeea4ef82ae99732c467d6245294bbed0e0fa426 | ||
| uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@d98caf412242294b1c9060cab2e30ecc9c55a0f7 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
The most appropriate fix is to add a permissions: block to the workflow at the top level. This block should appear immediately under the name: field and before the on: field. The minimal, safest default is contents: read, which restricts the workflow to only being able to read repository contents, unless a more permissive setting is required. If the reusable workflow needs additional permissions, then you’d need to consider that, but the CodeQL recommendation is to start with the minimal. Therefore, add the following lines after line 15:
permissions:
contents: readThis will ensure that, unless overridden in the reusable workflow or specific jobs, only read access is available.
-
Copy modified lines R16-R17
| @@ -13,6 +13,8 @@ | ||
| # limitations under the License. | ||
|
|
||
| name: Publish Dry Run | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
| jobs: | ||
| test: | ||
| uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@aeea4ef82ae99732c467d6245294bbed0e0fa426 | ||
| uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@d98caf412242294b1c9060cab2e30ecc9c55a0f7 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix this issue, you should add a permissions: block specifying the least required privilege for the workflow. Since this workflow only triggers a reusable workflow for CI purposes and likely does not require write access to repository contents, the minimal safe block would be:
permissions:
contents: readThis block should be placed at the top level, just below the name: key and above on:. If particular jobs required more permissions, you would set their permissions: blocks individually inside them, but here a minimal global block suffices. This change ensures the GITHUB_TOKEN will only have read-only access for repository contents during this workflow, reducing security risk.
-
Copy modified lines R16-R17
| @@ -13,6 +13,8 @@ | ||
| # limitations under the License. | ||
|
|
||
| name: Runtime | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
This PR contains the following updates:
aeea4ef->d98caf4Configuration
📅 Schedule: Branch creation - "on Sunday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.