Feat: set cancel on disconnect #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ball030
requested changes
Jan 30, 2026
| result = await self._private_api.rpc.get_account(params) | ||
| return result | ||
|
|
||
| async def set_cancel_on_disconnect(self, enabled: bool = True) -> Result: |
Owner
There was a problem hiding this comment.
There is no session for a async client.
Therefore this endpoint shouldnt be exposed on this endpoint type
Owner
There was a problem hiding this comment.
This is only relevant on websocket sessions
Collaborator
Author
There was a problem hiding this comment.
It's in the OpenAPI spec. This is an account-level (LightAccount wallet) operation. It may very well constitute a persistent state change at this level! Something you can toggle on and off.
| result = self._private_api.rpc.get_account(params) | ||
| return result | ||
|
|
||
| def set_cancel_on_disconnect(self, enabled: bool = True) -> Result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support and tests for
set_cancel_on_disconnectendpoint.Closes #194
Changes
set_cancel_on_disconnectendpoint support on theAccountOperationsmodule.