Skip to content

Conversation

@yanjustino
Copy link
Member

This pull request includes several updates across workflows, documentation, and code examples, focusing on removing outdated configurations, upgrading dependencies, and enhancing code clarity. Below is a summary of the most important changes:

Workflow Updates

  • Removed the codeql-analysis.yml workflow, which was used for CodeQL scanning, as it is no longer required.
  • Updated .github/workflows/dotnet.yml to use .NET 8.0 and 9.0, reflecting the latest framework versions. The VERSION and CLI_VERSION environment variables were also incremented accordingly. [1] [2]

Documentation Updates

  • Updated the README.md to specify that the library now requires .NET 8.0+ instead of .NET 5.0+.
  • Refactored code examples in the README.md to use modern C# syntax, improving readability and maintainability. For example, the DiagramBuilder implementation now uses object initializers and structured tuples. [1] [2]

Removal of Legacy Files

  • Removed C4_Component.puml and C4_Container.puml files from the docs/.c4s directory, as these were no longer in use or relevant to the current project setup. [1] [2]

@yanjustino yanjustino requested a review from Copilot July 19, 2025 01:33

This comment was marked as outdated.

@yanjustino yanjustino requested a review from Copilot July 19, 2025 01:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request includes several updates across workflows, documentation, and code examples, focusing on removing outdated configurations, upgrading dependencies, and enhancing code clarity.

  • Removes embedded C4-PlantUML resource files and updates the library to use PlantUML's C4 standard library instead
  • Upgrades framework support from .NET 6/7/8 to .NET 8/9 with version bumps
  • Modernizes C# code with collection expressions, improved object initializers, and cleaner syntax

Reviewed Changes

Copilot reviewed 61 out of 86 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/C4Sharp/Resources/*.puml Removes all embedded C4-PlantUML resource files (C4.puml, C4_Context.puml, etc.)
src/C4Sharp/C4Sharp.csproj Updates target frameworks to .NET 8/9 and bumps package version to 8.0.0
src/C4Sharp/Elements/Component.cs Refactors Component properties and improves operator overloads with modern syntax
src/C4Sharp/Diagrams/Plantuml/PlantumlDiagram.cs Simplifies diagram generation by using PlantUML standard library includes
samples/ModelDiagrams/Structures/*.cs Updates code examples to use named parameters and improved object initialization
Comments suppressed due to low confidence (1)

src/C4Sharp/Elements/Component.cs:19

  • [nitpick] Renaming ComponentType property to Type provides better clarity and follows common naming conventions, avoiding redundant naming.
    public ComponentType Type { get; init; } = ComponentType.None;

@yanjustino yanjustino merged commit 0bd6bcb into main Jul 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants