-
-
Notifications
You must be signed in to change notification settings - Fork 41
Develop #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #63
Conversation
… better maintainability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request includes several updates across workflows, documentation, and code examples, focusing on removing outdated configurations, upgrading dependencies, and enhancing code clarity.
- Removes embedded C4-PlantUML resource files and updates the library to use PlantUML's C4 standard library instead
- Upgrades framework support from .NET 6/7/8 to .NET 8/9 with version bumps
- Modernizes C# code with collection expressions, improved object initializers, and cleaner syntax
Reviewed Changes
Copilot reviewed 61 out of 86 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/C4Sharp/Resources/*.puml | Removes all embedded C4-PlantUML resource files (C4.puml, C4_Context.puml, etc.) |
| src/C4Sharp/C4Sharp.csproj | Updates target frameworks to .NET 8/9 and bumps package version to 8.0.0 |
| src/C4Sharp/Elements/Component.cs | Refactors Component properties and improves operator overloads with modern syntax |
| src/C4Sharp/Diagrams/Plantuml/PlantumlDiagram.cs | Simplifies diagram generation by using PlantUML standard library includes |
| samples/ModelDiagrams/Structures/*.cs | Updates code examples to use named parameters and improved object initialization |
Comments suppressed due to low confidence (1)
src/C4Sharp/Elements/Component.cs:19
- [nitpick] Renaming
ComponentTypeproperty toTypeprovides better clarity and follows common naming conventions, avoiding redundant naming.
public ComponentType Type { get; init; } = ComponentType.None;
This pull request includes several updates across workflows, documentation, and code examples, focusing on removing outdated configurations, upgrading dependencies, and enhancing code clarity. Below is a summary of the most important changes:
Workflow Updates
codeql-analysis.ymlworkflow, which was used for CodeQL scanning, as it is no longer required..github/workflows/dotnet.ymlto use .NET 8.0 and 9.0, reflecting the latest framework versions. TheVERSIONandCLI_VERSIONenvironment variables were also incremented accordingly. [1] [2]Documentation Updates
README.mdto specify that the library now requires .NET 8.0+ instead of .NET 5.0+.README.mdto use modern C# syntax, improving readability and maintainability. For example, theDiagramBuilderimplementation now uses object initializers and structured tuples. [1] [2]Removal of Legacy Files
C4_Component.pumlandC4_Container.pumlfiles from thedocs/.c4sdirectory, as these were no longer in use or relevant to the current project setup. [1] [2]