Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
Celso-Scott
approved these changes
Mar 11, 2025
Celso-Scott
left a comment
There was a problem hiding this comment.
Hi @domlatham I looked through all the changes today on the vercel branch and looked through the web display for the texts that I recall have unusual section structures, I didn't find any issues. It looks good to me. To double check I had a script printout all the file names in the data-static/translation directory and looked for anything that would be missed by the regex:
UT[0-9]+-\d+-\d+-\d
It all looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A new redirect that handles invalid links back to the translation found at the bottom of the source pages
e.g. https://84000.co/source/toh251/folio/1
The redirect works ok, but is a pragmatic fix that could impact other link functionality, most notably expanding translation sections. This should be tested thoroughly.
The change redirects requests to translations based on this regex
/translation/:work/:part(UT[\-0-9]+$)so for instance/translation/toh1-1/UT22084-001-001-chapter-1will pass through to load the chapter but/translation/toh1-1/UT22084-001-001-123will not.