Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41a21a80c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| result = await ai_client.agent_registry.execute_agent( | ||
| target_agent_name, args, context | ||
| ) |
There was a problem hiding this comment.
Isolate and retag context before calling another agent
This call forwards the original context directly into execute_agent, so nested agent calls run with the caller’s agent_name/state instead of the callee’s. In an A→B→C chain, C will still see agent_name=A, which can incorrectly allow/deny allowed_callers checks and leak/mutate caller-scoped fields (for example agent_history and runtime keys) across agents. Create a copied callee context and set callee identity before dispatch.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Respect configured default archive format
The end tool hardcodes zip when archive_format is omitted, but code_delivery_default_archive_format is parsed and documented as configurable. If operators set the default to tar.gz, deliveries will still be zipped unless the model explicitly passes archive_format, so runtime behavior diverges from configuration and can break downstream expectations.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Use path-aware boundary checks for workspace writes
The workspace guard uses string startswith, which is bypassed by sibling paths sharing the same prefix (for example ../workspace_backup/... resolves outside the workspace but still passes). That breaks the tool’s /workspace confinement guarantee and allows writes outside the intended root. Use Path.is_relative_to (or equivalent parent checks) on resolved paths.
Useful? React with 👍 / 👎.
功能概述
本 PR 新增了代码交付 Agent 和 Agent 互调用机制,显著增强了机器人的代码编写能力和 Agent 协作能力。
主要改动
1. 新增 code_delivery_agent(代码交付助手)
/workspace2. Agent 互调用功能
callable.json文件call_{agent_name}格式的工具名info_agent:可被所有 Agent 调用web_agent:可被所有 Agent 调用docs/agent-calling.md详细说明使用方法3. 提示词和配置优化
config.toml.example新增相关配置项config/loader.py支持更多配置选项4. 其他改进
技术细节
Agent 互调用实现
skills/agents/agent_tool_registry.pycallable.json控制访问权限code_delivery_agent 架构
skills/agents/runner.py统一执行入口utils/io.py确保原子性