fix: auto-detect platform to prevent silent data loss in Twitter-only simulations#168
Open
JasonOA888 wants to merge 2 commits into666ghj:mainfrom
Open
fix: auto-detect platform to prevent silent data loss in Twitter-only simulations#168JasonOA888 wants to merge 2 commits into666ghj:mainfrom
JasonOA888 wants to merge 2 commits into666ghj:mainfrom
Conversation
- Added VITE_API_TIMEOUT environment variable support - Default remains 300000ms (5 minutes) - Users can increase timeout for slow local models like Ollama - Example: VITE_API_TIMEOUT=600000 for 10 minutes Fixes 666ghj#58
… simulations Fixes 666ghj#150 ## Problem When a simulation is created with Twitter-only configuration (enable_reddit=false), all data retrieval APIs silently return empty results because they default to looking up Reddit data. No error is raised — the user sees an empty UI with no indication of what went wrong. ## Root Cause - Platform parameter hardcoded to 'reddit' in 3+ API locations - When Twitter-only simulation runs, reddit_simulation.db is never created - APIs still look for Reddit data by default → empty results → user confusion ## Solution 1. Added - checks which db files actually exist 2. Added - intelligent fallback logic 3. Updated all 3 API endpoints to use auto-detection ## Changes - backend/app/api/simulation.py: - Line 994: get_simulation_profiles() - Line 1108: get_simulation_profiles_realtime() - Line 2053: get_simulation_posts() ## Logic ## Testing - [x] Twitter-only simulation returns Twitter data (not empty) - [x] Reddit-only simulation still works - [x] Both-platform simulation defaults to Reddit (backward compatible) ## Impact Eliminates silent data loss for Twitter-only simulations
dosubot
bot
added
the
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150
Problem
When a simulation is created with Twitter-only configuration (
enable_reddit=false), all data retrieval APIs silently return empty results because they default to looking up Reddit data.Root Cause
'reddit'in 3+ API locationsreddit_simulation.dbSolution
detect_platform_from_simulation()- checks which db files existget_platform_with_fallback()- intelligent fallbackAffected Endpoints
/<simulation_id>/profiles/<simulation_id>/profiles/realtime/<simulation_id>/postsLogic
reddit_simulation.dbandtwitter_simulation.dbredditfor backward compatibilityTesting
Impact
Eliminates silent data loss for Twitter-only simulations