-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #18
Changes from all commits
0ac3353
281d90d
719a1c1
6ebb1ba
e5cb0ee
0ecdba0
7ebd15f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||
| <!-- header.php --> | ||||||
| <head> | ||||||
| <meta charset="UTF-8"> | ||||||
| <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no"> | ||||||
| <meta name="viewport" content="width=device-width, initial-scale=0.5"> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Questionable viewport scaling setting. Setting Consider using the standard responsive viewport setting: - <meta name="viewport" content="width=device-width, initial-scale=0.5">
+ <meta name="viewport" content="width=device-width, initial-scale=1.0">This will ensure the page displays at the intended size and works well with the responsive CSS being added. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| <link rel="stylesheet" href="../css/style.css"> | ||||||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||||||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||||||
|
|
@@ -19,6 +19,7 @@ | |||||
| <div class="nav-item"><a href="index.php?page=home">Home</a></div> | ||||||
| <div class="nav-item"><a href="index.php?page=home#team">Team</a></div> | ||||||
| <div class="nav-item"><a href="index.php?page=contactus">Contact us</a></div> | ||||||
| <div class="nav-item"><a href="index.php?page=agenda">Agenda</a></div> | ||||||
| <div class="nav-item"><a href="index.php?page=signup">Signup</a></div> | ||||||
| <div class="nav-item"><a href="index.php?page=history">History</a></div> | ||||||
| <div class="nav-item"><a href="index.php?page=results">Results</a></div> | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security concern: Environment variable exposure in debug output.
The
var_dump($_ENV)statement on line 11 could potentially expose sensitive environment variables (including database credentials, API keys, etc.) in production environments or logs.Consider these safer alternatives:
This approach logs the issue for debugging without exposing sensitive data to users.
📝 Committable suggestion
🤖 Prompt for AI Agents