feat: use websockets to update info on pages#33
Open
lmaotrigine wants to merge 1 commit into5HT2B:masterfrom
Open
feat: use websockets to update info on pages#33lmaotrigine wants to merge 1 commit into5HT2B:masterfrom
lmaotrigine wants to merge 1 commit into5HT2B:masterfrom
Conversation
Member
|
Oh thank you! I actually had websockets in mind once I realized gRPC was silly for this. |
5HT2
added
enhancement
Member
Author
|
great, thanks! |
lmaotrigine
force-pushed
the
feature/websockets
branch
from
14f2c9d to
49172cf
Compare
Member
|
Need to look into this, lgtm so far, is this a feature in the rust - rewrite already? @lmaotrigine |
Member
Author
|
sort of, yes. the current implementation is just a placeholder and it just polls the database anyway. it's one of many things i want to get around to eventually, but i haven't really had time lately. EDIT: just realised i did the same thing here lol, it's been so long. |
Member
|
Ah got it, I understand! A lot of my projects have been on the backburner for so long, also for time reasons. I will look into merging this and make a note for the future to improve this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Well, sort of. This currently does what I do in my rewrite (just send the JSON every second). Ideally, I'm thinking this should only send messages when the stats actually update, but then the interactive update of the relative times should be handled client-side, just like earlier so I'm undecided on whether to implement that or not.
In either case, this is an improvement over making an API request every second.