Skip to content

fix(envoy-plugin): Fix destination IP and port resolution and add TLS version#41

Merged
PrimalPimmy merged 1 commit into5GSEC:mainfrom
anurag-rajawat:fix-dest-info
Apr 22, 2025
Merged

fix(envoy-plugin): Fix destination IP and port resolution and add TLS version#41
PrimalPimmy merged 1 commit into5GSEC:mainfrom
anurag-rajawat:fix-dest-info

Conversation

@anurag-rajawat
Copy link
Contributor

Description

This PR:

  • Fixes a bug in destination IP address resolution which was using downstream connection local address. Now it uses Upstream connection remote address.
  • Adds a new header for TLS version being used in downstream and upstream TLS connection.

For ref: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/advanced/attributes#upstream-attributes

Does this PR introduce a breaking change?
No.

Checklist

  • PR title follows the <type>: <description> convention.
  • I use conventional commits in my commit messages.
  • I have updated the documentation accordingly.
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat anurag-rajawat self-assigned this Mar 13, 2025
@anurag-rajawat anurag-rajawat added the bug Something isn't working label Mar 13, 2025
@anurag-rajawat anurag-rajawat moved this to 👀 In review in SentryFlow Mar 13, 2025
@anurag-rajawat anurag-rajawat marked this pull request as draft March 13, 2025 12:40
@anurag-rajawat anurag-rajawat marked this pull request as ready for review March 14, 2025 15:45
… version

Signed-off-by: Anurag Singh Rajawat <anuragsinghrajawat22@gmail.com>
@PrimalPimmy PrimalPimmy merged commit 3d8d885 into 5GSEC:main Apr 22, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in SentryFlow Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants