BUG: Remove TAC and Native code from base PropertyKeyedEngine#719
Closed
YaroslavVlasenko wants to merge 1 commit intomainfrom
Closed
BUG: Remove TAC and Native code from base PropertyKeyedEngine#719YaroslavVlasenko wants to merge 1 commit intomainfrom
YaroslavVlasenko wants to merge 1 commit intomainfrom
Conversation
…n logic into dedicated builders: `TacEngineBuilder` and `NativeModelEngineBuilder`. Removed redundant configuration methods from `PropertyKeyedDeviceEngineBuilder`.
Contributor
|
@YaroslavVlasenko please see the parallel PR #720. This contains the refactoring I need to create the robots.txt engine. I'm unavailable tomorrow. Can you review these two PRs and see how they might be merged. |
Contributor
Author
@jwrosewell @justadreamer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#718
Extracted and refactored TAC and NativeModel engine configuratio…n logic into dedicated builders:
TacEngineBuilderandNativeModelEngineBuilder. Removed redundant configuration methods fromPropertyKeyedDeviceEngineBuilder.