This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Closed
Conversation
…and added the action type check
…ake it compatible with oca
…pi into feature/SHOWCASE-155 # Conflicts: # apps/credential-showcase-api-server/src/database/migrations/0003_credential-showcase-api.sql # apps/credential-showcase-api-server/src/database/migrations/meta/_journal.json # apps/credential-showcase-api-server/src/utils/mappers.ts
PR Deployment URLs ready for review. |
Brummos
suggested changes
Mar 21, 2025
Contributor
Brummos
left a comment
Brummos
left a comment
There was a problem hiding this comment.
i am not sure this PR actually addresses what the ticket describes, these credential representations have nothing to do with adding credentialDefinitions to steps?
| // credentialDefinition: credentialDefinitionResult.id | ||
| // }))) | ||
| // .returning(); | ||
| const credentialRepresentationsResult = |
Contributor
There was a problem hiding this comment.
why is this enabled? it says that we need this for SHOWCASE-81, and this should be out of scope. it was disabled for a reason because now the showcase builder needs to implement this
Contributor
Author
|
According to our last meeting, it should not be a credential associated to each step, but a credential definition. I'm closing this PR and starting over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.