This repository was archived by the owner on Mar 27, 2025. It is now read-only.
chore: implemented expand QPs for showcase#52
Open
sanderPostma wants to merge 11 commits intodevelopfrom
Open
Conversation
sanderPostma
commented
Mar 14, 2025
| "scripts": { | ||
| "start": "ts-node src/index.ts", | ||
| "dev": "ts-node-dev src/index.ts", | ||
| "dev": "ts-node-dev --transpile-only src/index.ts", |
Contributor
Author
There was a problem hiding this comment.
Resolves 3min startup time
Brummos
suggested changes
Mar 14, 2025
|
|
||
| @Get('/') | ||
| public async getAll(): Promise<ShowcasesResponse> { | ||
| public async getAll(@QueryParam('expand') expand?: ShowcaseExpand[]): Promise<ShowcasesResponse> { |
Contributor
There was a problem hiding this comment.
i do not see id's being returned. now it is returning empty arrays
|
|
||
| @Get('/:slug') | ||
| public async getOne(@Param('slug') slug: string): Promise<ShowcaseResponse> { | ||
| public async getOne(@Param('slug') slug: string, @QueryParam('expand') expand?: ShowcaseExpand[]): Promise<ShowcaseResponse> { |
Contributor
There was a problem hiding this comment.
i do not see id's being returned. now it is returning empty arrays
| const getResponse = await request.get(`/showcases/${createdShowcase.slug}`).expect(200) | ||
|
|
||
| // Verify no related entities are expanded | ||
| expect(getResponse.body.showcase.scenarios).toEqual([]) |
Contributor
There was a problem hiding this comment.
should we not check on id's here?
| // Create a properly typed array for scenarios | ||
| const scenariosArray: Scenario[] = [] | ||
|
|
||
| for (const scenarioJoin of result.scenarios) { |
| if (expandSet.has(ShowcaseExpand.PERSONAS) && 'personas' in result && Array.isArray(result.personas)) { | ||
| const personasArray: Persona[] = [] | ||
|
|
||
| for (const personaJoin of result.personas) { |
| credentialDefinition: { | ||
| with: { | ||
| icon: true, | ||
| ...(expandSet.has(ShowcaseExpand.ASSET_CONTENT) ? { icon: true } : {}), |
Contributor
There was a problem hiding this comment.
...(expandSet.has(ShowcaseExpand.ASSET_CONTENT) && { icon: true })
| const scenarioItems = scenariosMap.get(showcaseData.id) || [] | ||
| const scenariosArray: Scenario[] = [] | ||
|
|
||
| for (const scenarioJoin of scenarioItems) { |
|
|
||
| public getShowcases = async (): Promise<Showcase[]> => { | ||
| return this.showcaseRepository.findAll() | ||
| public getShowcases = async (expand?: ShowcaseExpand[]): Promise<Showcase[]> => { |
Contributor
There was a problem hiding this comment.
can we create an params object for these functions? this extends much nicer in the future
| export const normalizeExpandParams = (expand?: string[]): ShowcaseExpand[] => { | ||
| const expandMap: Record<string, ShowcaseExpand> = { | ||
| scenarios: ShowcaseExpand.Scenarios, | ||
| credentialdefinitions: ShowcaseExpand.CredentialDefinitions, |
Contributor
There was a problem hiding this comment.
why do we have these double? with snake case?
Contributor
Author
There was a problem hiding this comment.
yes it gives some upper/lower/snake case flexibility
Contributor
|
Also tests are failing, run pnpm test from the root |
ronal2do
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.