Conversation
…pi into feature/SHOWCASE-153 # Conflicts: # apps/credential-showcase-api-server/src/database/schema/stepAction.ts # pnpm-lock.yaml
| const actionsResult = await tx | ||
| .insert(stepActions) | ||
| .values( | ||
| // @ts-ignore |
There was a problem hiding this comment.
why do we need to ignore?
There was a problem hiding this comment.
The values() function does not accept undefined and the compiler complains. However you just made me realize that there was an issue in my code. Refactored
| const proofRequestsResult = await tx | ||
| .insert(ariesProofRequests) | ||
| .values( | ||
| // @ts-ignore |
There was a problem hiding this comment.
why do we need to ignore?
There was a problem hiding this comment.
The values() function does not accept undefined and the compiler complains. However you just made me realize that there was an issue in my code. Refactored
| "title" text NOT NULL, | ||
| "text" text NOT NULL, | ||
| "step" uuid NOT NULL, | ||
| "step" uuid, |
There was a problem hiding this comment.
we need new migrations, do not change older ones
There was a problem hiding this comment.
Created a new migration file and rolled back the changes in the existing one
… new value of actions undefined
…pi into feature/SHOWCASE-153
…pi into feature/SHOWCASE-153 # Conflicts: # apps/credential-showcase-api-server/src/database/migrations/0003_credential-showcase-api.sql # apps/credential-showcase-api-server/src/utils/mappers.ts
PR Deployment URLs ready for review. |
| actions: actionsResult.map((action) => ({ | ||
| ...action, | ||
| step: stepResult.id, | ||
| proofRequest: proofRequestsResult.find((proofRequest) => proofRequest.stepAction === action.id), |
There was a problem hiding this comment.
The code comes from development. The second return statement is mine
…pi into feature/SHOWCASE-153 # Conflicts: # apps/credential-showcase-api-server/src/database/migrations/0003_credential-showcase-api.sql
…pi into feature/SHOWCASE-153 # Conflicts: # apps/credential-showcase-api-server/src/database/migrations/0003_credential-showcase-api.sql
3 participants
No description provided.