This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Conversation
…onal in the credential definition request in Open API
ronal2do
reviewed
Mar 14, 2025
| ) {} | ||
|
|
||
| async create(credentialDefinition: NewCredentialDefinition): Promise<CredentialDefinition> { | ||
| if (!credentialDefinition.icon) { |
ronal2do
reviewed
Mar 14, 2025
...wcase-api-server/src/database/repositories/__tests__/credentialDefinition.repository.test.ts
Show resolved
Hide resolved
Brummos
suggested changes
Mar 14, 2025
| "identifier_type" "IdentifierType", | ||
| "identifier" text, | ||
| "credential_schema" uuid NOT NULL, | ||
| "icon" uuid NOT NULL, |
Contributor
There was a problem hiding this comment.
we need new migrations, do not change older ones
Contributor
Author
There was a problem hiding this comment.
Rolled back the changes and created a new migration file
…pi into feature/SHOWCASE-152 # Conflicts: # apps/credential-showcase-api-server/src/database/schema/credentialDefinition.ts # pnpm-lock.yaml
ronal2do
reviewed
Mar 17, 2025
| await this.findById(id) | ||
|
|
||
| if (!credentialDefinition.icon) { | ||
| return Promise.reject('Icon is required') |
Contributor
There was a problem hiding this comment.
icon is no longer required
…he insertion of undefined credentialDefinitions
ronal2do
approved these changes
Mar 21, 2025
…pi into feature/SHOWCASE-152 # Conflicts: # apps/credential-showcase-api-server/src/database/migrations/0003_credential-showcase-api.sql # apps/credential-showcase-api-server/src/database/migrations/meta/_journal.json
PR Deployment URLs ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.