Skip to content

Conversation

@bobobo1618
Copy link

Adds a Flickr API based ripper. Depends on #286 at the moment.

I know all the PRs I'm sending will need a lot of cleaning.

@hrxn
Copy link

hrxn commented Jan 3, 2016

Nice work..

I also like the idea of different storage back-ends.

But right now this PR has 4 commits and 90 files changed. Maybe that is a bit much.
I think it would be easier to split it up in different parts.
And, for example, start just with one or two rippers, test and merge, and then adapt all the other different rippers?

@bobobo1618
Copy link
Author

@hrxn that'd be good but since I've changed the constructor and AbstractRipper, which all other rippers depend on, I don't think it's feasible to break it up like that.

Flickr definitely shouldn't be in here though, I'm not sure how that happened...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants