Apply unicode normalization before checking for spam #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents spammers from using visual identical unicode characters to bypass detection.
Owner
|
The only thing that worries me is the possible overhead of using the Normalizer class in all chat and command executions, in your other pull request everything is perfect since it is behind a configuration option, but here, even though you drop the use of equalsIgnoreCase for an equals, I don't know how much pressure it can take to use the Normalizer |
Contributor
Author
|
According to https://unicode-org.github.io/icu-perf/results/ustrperf/TestNames_Latin/, normalizing a character would take no longer than tens of nanoseconds. As a message can have a maximum of 256 characters, it would not have much impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents spammers from using visual identical unicode characters to bypass detection.