Replace Eclipse Jersey with Spring MVC #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that was reading didn't handle reads with offsets properly.
AemProxy tests are failing but other tests are working.
Since we always "dechunk" it in the proxy code, we do not want to pass the transfer encoding header back *from* the proxy code.
Originally, the code used an Adaptive Form recording, but when the TestContainers code was created, it used an HTML5 form instead. At that time, the WireMock recordings weren't updated so the WireMock tests still used the Adaptive Form. Now both WireMock and TestContainers tests use the same HTML5 form and so the same container image (running on port 4502) can be used to re-create the WireMock recordings.
This will mean that it will only be used if no other RestClientFactory beans are available (i.e. JerseyRestClientFactory is not available). This should allow the Jersey autoconfiguration to provide the JerseyRestClientFactory without creating a conflict.
SpringMVC implementation can now be overridden by having other autoconfigurations override it (as in the case of fluentforms-jersey-spring-boot-starter). It can also be overridden via an explicit configuration setting (fluentforms.rproxy.type).
It was @Autowired as a holdover from when it used JAX-RS Jersey implementation, but that is not required for Spring. Constructor injection is to be preferred over being @Autowired.
Renamed existing CI and updated to distinguish webmvc from jersey.
By default the pom.xml in the parent directory is detected which conflicts with the <parent> location for spring boot projects.
Sample projects and compositing pom.xml files don't need to be installed or deployed to the maven repos, so we now exclude them from these steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of Jersey (by default) with Spring MVC, thus eliminating the dependency on Jersey (and on spring-boot-jersey-starter).
Created a separate spring boot starter that uses Jersey for backwards compatibility. Existing applications can switch to it if they encounter issues with the WebMVC implementation.