Skip to content

chore: Limit superqt version bellow 0.8.0 when install pyside2 as qt backend#1374

Merged
Czaki merged 2 commits intodevelopfrom
pyside_superqt
Mar 26, 2026
Merged

chore: Limit superqt version bellow 0.8.0 when install pyside2 as qt backend#1374
Czaki merged 2 commits intodevelopfrom
pyside_superqt

Conversation

@Czaki
Copy link
Collaborator

@Czaki Czaki commented Mar 25, 2026

Summary by CodeRabbit

  • Chores
    • Tightened optional dependency constraints for the PySide2 extras by adding an upper bound on the SuperQt package to improve compatibility and prevent incompatible versions.
    • No other dependency groups or core requirements were changed.

@Czaki Czaki added this to the 0.17.0 milestone Mar 25, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 96ad32ef-77bf-4f0c-a3d6-6e46d637562c

📥 Commits

Reviewing files that changed from the base of the PR and between 7cc56be and 278a044.

📒 Files selected for processing (1)
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

Added an upper-version bound superqt<0.8.0 to the pyside2 optional-dependencies group in pyproject.toml.

Changes

Cohort / File(s) Summary
Dependency Constraint
pyproject.toml
Added superqt<0.8.0 to the pyside2 optional-dependencies group; no other dependency groups or core requirements changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny hop in config land, a version line so neat,
superqt now knows its fence, small bounds beneath my feet.
PySide2 whispers thanks in code, dependencies align,
A rabbit's cheer for tidy specs — one constraint, sublime! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a version constraint for superqt when using pyside2 as the Qt backend, which matches the pyproject.toml modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pyside_superqt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
pyproject.toml (1)

134-138: Consider adding an explanatory comment to clarify the PySide2 compatibility constraint.

The superqt<0.8.0 constraint is correct—superqt 0.8.0 dropped PySide2 support, keeping only PyQt5, PyQt6, and PySide6. Adding a brief inline comment (e.g., # superqt 0.8.0 dropped PySide2 support) would improve clarity for future maintainers.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` around lines 134 - 138, Add an inline explanatory comment
next to the pyside2 dependency block explaining why superqt is constrained
(e.g., note that "superqt<0.8.0" is required because superqt 0.8.0 dropped
PySide2 support); update the dependency list containing pyside2,
"napari[pyside]<0.7.0", and "superqt<0.8.0" to include that brief comment so
future maintainers understand the compatibility constraint.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pyproject.toml`:
- Around line 134-138: Add an inline explanatory comment next to the pyside2
dependency block explaining why superqt is constrained (e.g., note that
"superqt<0.8.0" is required because superqt 0.8.0 dropped PySide2 support);
update the dependency list containing pyside2, "napari[pyside]<0.7.0", and
"superqt<0.8.0" to include that brief comment so future maintainers understand
the compatibility constraint.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7ada348c-1e20-4aca-973b-1e1ebab12634

📥 Commits

Reviewing files that changed from the base of the PR and between 0331e67 and 7cc56be.

📒 Files selected for processing (1)
  • pyproject.toml

@Czaki Czaki changed the title chore: Limit superqt version bellow 0.8.0 when install pyside2 backend chore: Limit superqt version bellow 0.8.0 when install pyside2 as qt backend Mar 25, 2026
@sonarqubecloud
Copy link

@Czaki Czaki added the skip check PR title skip spellcheking PR title label Mar 26, 2026
@Czaki Czaki merged commit 69255d8 into develop Mar 26, 2026
67 of 69 checks passed
@Czaki Czaki deleted the pyside_superqt branch March 26, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip check PR title skip spellcheking PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant