chore: Limit superqt version bellow 0.8.0 when install pyside2 as qt backend#1374
chore: Limit superqt version bellow 0.8.0 when install pyside2 as qt backend#1374
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded an upper-version bound Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
134-138: Consider adding an explanatory comment to clarify the PySide2 compatibility constraint.The
superqt<0.8.0constraint is correct—superqt 0.8.0 dropped PySide2 support, keeping only PyQt5, PyQt6, and PySide6. Adding a brief inline comment (e.g.,# superqt 0.8.0 dropped PySide2 support) would improve clarity for future maintainers.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` around lines 134 - 138, Add an inline explanatory comment next to the pyside2 dependency block explaining why superqt is constrained (e.g., note that "superqt<0.8.0" is required because superqt 0.8.0 dropped PySide2 support); update the dependency list containing pyside2, "napari[pyside]<0.7.0", and "superqt<0.8.0" to include that brief comment so future maintainers understand the compatibility constraint.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Around line 134-138: Add an inline explanatory comment next to the pyside2
dependency block explaining why superqt is constrained (e.g., note that
"superqt<0.8.0" is required because superqt 0.8.0 dropped PySide2 support);
update the dependency list containing pyside2, "napari[pyside]<0.7.0", and
"superqt<0.8.0" to include that brief comment so future maintainers understand
the compatibility constraint.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7ada348c-1e20-4aca-973b-1e1ebab12634
📒 Files selected for processing (1)
pyproject.toml
|



Summary by CodeRabbit