Skip to content

Shiny app in mesh building tutorial is stuck #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnky9800n merged 2 commits into from
Jan 4, 2025
Merged

Shiny app in mesh building tutorial is stuck #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d1a62
Changed the default parameters
aabelean Dec 18, 2024
f6b8442
Corrected the error in text
aabelean Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions R/shiny_meshbuilder.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ meshbuilder_shiny <- function(
stop("Cannot read latitude and longitude data from spatial data. Please ensure given names are correct.")
}

default_max_edge_min <- 0.01
default_max_edge_max <- 0.3
default_max_edge_min <- 0.9
default_max_edge_max <- 1.8
default_offset_min <- 0.02
default_offset_max <- 0.2
default_offset_max <- 2
default_cutoff <- 0.02
# TODO - these defaults need changing?
if (!is.null(max_edge)) {
Expand Down Expand Up @@ -234,7 +234,7 @@ meshbuilder_shiny <- function(
spatial_data
}
})

output$map <- leaflet::renderLeaflet({
map_tiles <- c("OpenStreetMap", "Esri.WorldImagery", "OpenTopoMap")
m <- mapview::mapview(mesh_spatial(), layer.name = "Mesh", col.regions = "#548C2F", map.types = map_tiles) + mapview::mapview(spatial(), layer.name = "Spatial")
Expand Down
2 changes: 1 addition & 1 deletion vignettes/meshbuilder.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ sp_data <- fdmr::load_tutorial_data(dataset = "covid", filename = "spatial_data.
head(sp_data)
```

The `sp_data` object is a `SpatialPolygonsDataFrame` containing 6789 features for areas of England. This object contains all the contains all the values we
The `sp_data` object is a `SpatialPolygonsDataFrame` containing 6789 features for areas of England. This object contains all the values we need to build a mesh.
We can build a mesh by passing `sp_data` to the `mesh_builder` function.

```{r eval=FALSE}
Expand Down
Loading